Skip to content

feat: add ad cookies for GDPR#4448

Merged
brunobesson merged 1 commit into
masterfrom
ad-cookies
Oct 18, 2025
Merged

feat: add ad cookies for GDPR#4448
brunobesson merged 1 commit into
masterfrom
ad-cookies

Conversation

@brunobesson
Copy link
Copy Markdown
Member

@brunobesson brunobesson commented Oct 18, 2025

Summary by CodeRabbit

  • New Features
    • Added Advertisement cookies preference section to GDPR consent modal, enabling users to independently manage personalized advertising consent alongside existing statistical and social media cookie options.

@brunobesson brunobesson changed the title Add ad cookies for GDPR feat: add ad cookies for GDPR Oct 18, 2025
@brunobesson brunobesson merged commit 6a63fc0 into master Oct 18, 2025
3 of 5 checks passed
@brunobesson brunobesson deleted the ad-cookies branch October 18, 2025 19:36
@github-actions github-actions Bot added the enhancement New feature or request label Oct 18, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Oct 18, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Introduces Advertisement cookies UI component in GdprModal alongside existing cookie consent sections, with corresponding state management updates in the GDPR plugin to include an ad flag in the setAll payload. A potential reactivity issue exists where the Vue component references gdpr.ad but the script data model does not define this property.

Changes

Cohort / File(s) Summary
UI Advertisement Cookies Block
src/components/gdpr/GdprModal.vue
Adds new Advertisement cookies column section with checkbox bound to gdpr.ad, descriptive text about personalized advertising, and layout restructuring. Note: ad property not defined in component's data model.
GDPR Plugin State Update
src/js/vue-plugins/gdpr.js
Extends setAll() function to dispatch ad flag alongside existing statistics and social flags in payload.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

The changes are localized and follow existing patterns, but require verification of the gdpr.ad reactivity issue in the component data model and confirmation that the ad flag integrates properly with downstream logic.

Poem

🐰 A new cookie consent, so shiny and bright,
Advertisement preferences tucked in just right,
Yet one little hiccup—a property lost,
Define what you bind, or pay the true cost! ✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ad-cookies

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c665591 and de15025.

📒 Files selected for processing (2)
  • src/components/gdpr/GdprModal.vue (1 hunks)
  • src/js/vue-plugins/gdpr.js (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant